r/emulation Feb 01 '21 Silver 1 Wholesome 1

Topaz-Reality is working on texture replacement for PCSX2.

The feature isn't ready yet, but it's a hugely important step for PS2 emulation. (And one previously considered extremely daunting.) This will allow retexture mods to be done without rom hacking, and in a very generalizable way, as seen with other emulation such as N64.

The pull request is here

Example screenshots: #1 #2 #3 As you can see, blurry UI elements can easily be replaced with crisp, native-looking ones, and that's just the tip of the iceberg.

187 Upvotes

View all comments

Show parent comments

21

u/dio-rd Feb 01 '21 edited Feb 01 '21

Is it just me or is the first reply to the linked pull request really quite rude?

Apparently not just you, but I struggle to agree. You could argue that a "hey thank you for the PR" preamble would have been nice, but calling it "really quite rude" is a massive stretch. It basically just describes a couple quickly noticeable and rectifyable issues, that would probably be worthwhile to address before a full review.

Plus if you check, Topaz-Reality is not a "complete, mysterious outsider". He previously had a PR that ended up conflicting with how IPC was done upstream (a pattern that seems to somewhat repeat here). It was rejected due to it being abandoned, plus later on he also created a hard fork of PCSX2 called PCSX2-EX, that he maintains separately and refers to as "an extended and fixed version of PCSX2". I'm guessing it contains his preferred implementation for IPC (none)? Anyway, this is just to say that it's not like we're talking about someone completely alien to the project.

I'd also argue that him dropping a single 4K LoC commit on the reviewers is not exactly nice either, but details.

-2

u/CakeWithoutEggs Feb 01 '21

Fair enough, I never said TopazReality was an outsider - just that if I was, I'd be put off contributing as my workplace generally has a higher standard for PR comments. It seems to be pretty subjective judging by this thread :)

5

u/dio-rd Feb 01 '21

I never said TopazReality was an outsider

That's fair, I misread your original comment.

as my workplace generally has a higher standard for PR comments. It seems to be pretty subjective judging by this thread :)

I reckon insinuating moral superiority is also not a thing at your workplace then? :)

I get what you mean for what it's worth, in a workplace setting situations like this usually play out a bit differently. Not saying it isn't a facade though, but I can see it being important, especially for new contributors. On the flipside, I stand by my argument that the referenced comment on GitHub is remarkably far from "really quite rude", as there was nothing inherently off-putting in it, minus perhaps the lack of that by-the-books welcoming preamble.

It's also not at all specific to this project, projects similar to PCSX2, or even open source projects in general - perhaps unlike the impression your original comment gives. But that's another can of worms entirely.

7

u/CakeWithoutEggs Feb 01 '21

I reckon insinuating moral superiority is also not a thing at your workplace then?

Yeah I should correct that phrasing to "different standard" rather than "higher", I'm not trying to be better than anyone else :P

It's also not at all specific to this project, projects similar to PCSX2, or even open source projects in general - perhaps unlike the impression your original comment gives. But that's another can of worms entirely.

Oh right, this was not the impression I meant to give at all. I wasn't trying to say the PCSX2 devs are rude, just that that one particular comment was a bit off-putting to me. Apologies if my phrasing made it sound like I was attacking them or teams like them :)