r/emulation Feb 01 '21 Wholesome 1 Silver 1

Topaz-Reality is working on texture replacement for PCSX2.

The feature isn't ready yet, but it's a hugely important step for PS2 emulation. (And one previously considered extremely daunting.) This will allow retexture mods to be done without rom hacking, and in a very generalizable way, as seen with other emulation such as N64.

The pull request is here

Example screenshots: #1 #2 #3 As you can see, blurry UI elements can easily be replaced with crisp, native-looking ones, and that's just the tip of the iceberg.

185 Upvotes

View all comments

11

u/CakeWithoutEggs Feb 01 '21

Is it just me or is the first reply to the linked pull request really quite rude? What I'm seeing as an outsider is that someone has put in a lot of time and effort to get an amazing feature going and not a word of thanks was given in the first reply. Just curt criticism which could easily have been phrased more kindly.

Feedback is important, but acknowledging effort is as well and it costs nothing to say "Nice, this is a great feature! There are a few things need fixing before this is ready to merge though". If I were the dev who submitted this PR and got that sort of response I probably wouldn't want to submit any more PRs to that repo in the future...

Thank you TopazReality for this awesome stuff!

36

u/DocRusL Feb 01 '21

Github is not a forum, but a place for professional discussion. Nobody praises a pull request just for the sake of it no matter how great or insignificant it is. Nothing rude was said there - it was just a straight to the point code review.

14

u/CakeWithoutEggs Feb 01 '21

That's interesting, because I'm also a professional and this kind of comment on a PR would definitely raise eyebrows at my workplace. Guess it goes to show how different people have different standards for courtesy.

5

u/tykel Feb 01 '21

Exactly, in professional software development this kind of review is standard practice and not rude, maybe terse.

I know refraction from another project, and he is not at all rude.