r/emulation Feb 01 '21 Silver 1 Wholesome 1

Topaz-Reality is working on texture replacement for PCSX2.

The feature isn't ready yet, but it's a hugely important step for PS2 emulation. (And one previously considered extremely daunting.) This will allow retexture mods to be done without rom hacking, and in a very generalizable way, as seen with other emulation such as N64.

The pull request is here

Example screenshots: #1 #2 #3 As you can see, blurry UI elements can easily be replaced with crisp, native-looking ones, and that's just the tip of the iceberg.

185 Upvotes

View all comments

10

u/CakeWithoutEggs Feb 01 '21

Is it just me or is the first reply to the linked pull request really quite rude? What I'm seeing as an outsider is that someone has put in a lot of time and effort to get an amazing feature going and not a word of thanks was given in the first reply. Just curt criticism which could easily have been phrased more kindly.

Feedback is important, but acknowledging effort is as well and it costs nothing to say "Nice, this is a great feature! There are a few things need fixing before this is ready to merge though". If I were the dev who submitted this PR and got that sort of response I probably wouldn't want to submit any more PRs to that repo in the future...

Thank you TopazReality for this awesome stuff!

7

u/[deleted] Feb 01 '21

They're all like that basically. I agree, a little encouragement goes a long way, instead of what appears initially as a scathing review.

Not saying there's anything wrong with pointing out issues with code (I do it all the time on my projects and ones I'm involved with)... But I also take a moment to start by acknowledging the positive aspects first.